Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Datadog as an exporter for OTLP traces #2083

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Conversation

yquansah
Copy link
Contributor

@yquansah yquansah commented Sep 4, 2023

Add documentation for using Datadog as a potential exporter for OTLP traces.

Completes FLI-581

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2083 (68599ae) into main (79a51ff) will not change coverage.
The diff coverage is n/a.

❗ Current head 68599ae differs from pull request most recent head d0a42e7. Consider uploading reports for the commit d0a42e7 to get more accurate results

@@           Coverage Diff           @@
##             main    #2083   +/-   ##
=======================================
  Coverage   70.41%   70.41%           
=======================================
  Files          70       70           
  Lines        6822     6822           
=======================================
  Hits         4804     4804           
  Misses       1741     1741           
  Partials      277      277           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, couple suggestions

examples/tracing/otlp/README.md Outdated Show resolved Hide resolved

**Note:** The `DD_API_KEY` should be replaced with your actual api key from Datadog.

You can do this under the extensions configuration. You also have to add `datadog` as an entry in `exporters` under `service.pipelines.traces.exporters`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do what under the extensions configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markphelps Simplified the wording on this.

examples/tracing/otlp/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that was a much more simple experience :D

@yquansah yquansah merged commit cac1e65 into main Sep 5, 2023
21 checks passed
@yquansah yquansah deleted the yq-dd-exporter branch September 5, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants