-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Datadog as an exporter for OTLP traces #2083
Conversation
749e2f3
to
45ff02b
Compare
45ff02b
to
367a80d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2083 +/- ##
=======================================
Coverage 70.41% 70.41%
=======================================
Files 70 70
Lines 6822 6822
=======================================
Hits 4804 4804
Misses 1741 1741
Partials 277 277 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question, couple suggestions
examples/tracing/otlp/README.md
Outdated
|
||
**Note:** The `DD_API_KEY` should be replaced with your actual api key from Datadog. | ||
|
||
You can do this under the extensions configuration. You also have to add `datadog` as an entry in `exporters` under `service.pipelines.traces.exporters`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do what under the extensions configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markphelps Simplified the wording on this.
68599ae
to
f33ff51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, that was a much more simple experience :D
Add documentation for using Datadog as a potential exporter for
OTLP
traces.Completes FLI-581